0.48.3.3 Par2 issue when uploads not rared

[Sucker76]

Here is an NZB to test: *removed*

The upload took place directly without the files being packed.
An item is missing and despite sufficient Par2 files, no repair is carried out.

[Rdl]

[29.8.2024 21:04:43] [PAR2&Unrar] Core Keeper-Razor1911.par2 needs 587 more blocks, 119 available

This indicates why no recovery par2 were not downloaded.
There were only 7 blocks detected on large iso instead of 593. Why?
Short story, previous nzb you posted with directories inside filenames... I've created few nzbs with some articles missing, directory structure was ok, but in one case checkfile function was producing access violation. I've tried to debug/look into source, buy my younger self overcomplicated that code so much that I was not able to understand wtf was going on.
So, I've decided to write new checkfile function that I would understand fully, but in all my wisdom, I've decided to speed up the process with using openAI (what-a mistake-a to make-a)
It took couple of hours, mostly waiting for damn thing to spit up revised code after numerous pointing of obvious mistakes. But, obviously, error/s remain/s, which this example exploited. I thing I know what the problem is, I'll take a look tomorrow.
Old checkfile function combined with  directory handling produces correct results

[Sucker76]

Thanks rdl.
I hope you can manage this.
But it doesn't have to be right away...

[Rdl]

should be fixed  in 0.48.3.4

[Rdl]

BTW, what is the story with those uploads with directory structure. I really, really hope it doesn't lead to anyone not using setup->Download->Create subfolders based on NZB/root node name.
You SHOULD ALWAYS USE THAT OPTION, unless you really know what you're doing. It only leads to lots of problems not using that one.

[Sucker76]

Hi.
Thank you for your work, but unfortunately it doesn't work that reliably.
See enclosed NZB (and log).

No, it's not about someone not wanting to create subfolders.
The reason is Usenet portals such as House of Usenet (and also other indexer sites). It probably protects the uploader's SSD if no RAR archives are created, but the uploads take place directly.
The password protection that no longer exists is then replaced by obfuscation.

In addition to updates for games, this constellation can also occur with complete series, where the individual episodes are stored separately in subfolders.

The downloads should be faster because there is no longer any need to unpack.
That can be good or bad, but I also see the disadvantage that the Par2 check only takes place when the download is complete, so with large files this may even take longer than unpacking from RAR archives.
But that's just how it's advertised.

[Rdl]

That one was easy... .5

[Sucker76]

Good mornin rdl.

I was worried you would think I was kidding you or something 

But I just did some testing and now (0.48.3.6) it really seems to be running correctly.
Incomplete files are restored correctly and the directories are also preserved.

I can only imagine how annoying it was for you to find the cause and fix it.

It works as it should.
Thanks alot!